chore(#9471): ui nav work image replacement - contact and user management #9505

lorerod · 2024-10-04T16:07:06Z

Description

closes #9471

Code review checklist

Readable: Concise, well named, follows the style guide, documented if necessary.
Documented: Configuration and user documentation on cht-docs
Tested: Unit and/or e2e where appropriate
Internationalised: All user facing text
Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

lorerod · 2024-10-11T22:12:06Z

Hi @latin-panda! If you can review this, I have some doubts about this change, and you may know a better way to proceed.

Adding immunization condition card selectors in tests/page-objects/default/contacts/contacts.wdio.page.js, but immunization is not a part of the default config.
Adding forms in tests/e2e/visual/contacts/forms where the only difference to the default config forms is in properties not to show the form or change its name for the care guides screenshot.
Appreciate it!

latin-panda

Thanks for sending this Lore!

I only covered 50% of the files, it's slow to review because many new lines and checking things around the new code
So submitting the first half and then I'll continue the other later

package.json

tests/utils/index.js

tests/page-objects/default/users/user.wdio.page.js

tests/page-objects/default/sort/sort.wdio.page.js

tests/factories/cht/generate.js

tests/factories/cht/reports/inmunization.js

latin-panda

@lorerod Looking very good! I reviewed 17 of 23 files, tomorrow I'll continue with the other ones. But submitting some of the feedback and questions now

tests/e2e/visual/wdio.conf.js

tests/page-objects/default/common/common.wdio.page.js

tests/utils/index.js

tests/page-objects/default/contacts/contacts.wdio.page.js

latin-panda · 2024-10-29T11:46:07Z

tests/e2e/visual/contacts/config/contact-summary-extras.js

This is a lot of code (572 lines) and needs some fixes to align it with our standard. Before I dive into this file, I want to make sure... Do we really need all this? 😅

@latin-panda , the only difference from the default config contact-summary-extras.js file is that I added what is necessary to support immunization. Do you know if there is a more straightforward way to add does to the test config?

The same happens to me with the forms.

latin-panda · 2024-10-29T11:46:24Z

tests/e2e/visual/contacts/config/contact-summary.templated.js

Same as before.

This is a lot of code (477 lines) and needs some fixes to align it with our standard. Before I dive into this file, I want to make sure... Do we really need all this? 😅

Maybe we can work out only the necessary

latin-panda

@lorerod I finished reviewing, please find below the other part of the feedback

tests/e2e/visual/contacts/contact-user-hierarchy-creation.wdio-spec.js

tests/factories/cht/generate.js

tests/page-objects/default/sort/sort.wdio.page.js

latin-panda

It's almost ready! 🤩 Just some small comments below

tests/e2e/visual/contacts/contact-user-hierarchy-creation.wdio-spec.js

tests/e2e/visual/contacts/contact-user-management.wdio-spec.js

tests/factories/cht/generate.js

tests/page-objects/default/common/common.wdio.page.js

tests/page-objects/default/contacts/contacts.wdio.page.js

latin-panda · 2024-11-25T09:48:11Z

@lorerod is it ready for review? I'm available if you need :)

lorerod · 2024-11-25T12:12:31Z

@latin-panda I'm Sorry. Last week, I was busy fixing the cht-sync e2e failure at the main branch. I will work on this as a priority this week. Thank you!

…ssions

Co-authored-by: Jennifer Q <[email protected]>

…ings Co-authored-by: Jennifer Q <[email protected]>

Co-authored-by: Jennifer Q <[email protected]>

…lector private

Co-authored-by: Jennifer Q <[email protected]>

lorerod force-pushed the 9471-ui-nav-image-test-contact-user-management branch from 2156755 to f7872f7 Compare October 4, 2024 16:20

lorerod marked this pull request as ready for review October 8, 2024 23:13

lorerod requested a review from latin-panda October 11, 2024 21:59

latin-panda requested changes Oct 14, 2024

View reviewed changes

lorerod requested a review from latin-panda October 25, 2024 20:04

latin-panda requested changes Oct 29, 2024

View reviewed changes

latin-panda requested changes Oct 30, 2024

View reviewed changes

lorerod requested a review from latin-panda November 13, 2024 16:16

latin-panda requested changes Nov 15, 2024

View reviewed changes

dianabarsan mentioned this pull request Nov 19, 2024

chore(#9585): teach Sentinel sign language #9658

Merged

5 tasks

Maria Lorena Rodriguez Viruel and others added 17 commits November 28, 2024 11:23

show contact list, search, profiles, contact summary, sort

f73c4d7

add condition cards and care guides

9f6a61e

factor update settings

631c6e5

move contact summary to config folder

f347429

add inmunization condition card screenshot

82bfaa8

fix eslint

8438c12

fix eslint in contact summary config

713ca8f

revert pregnancy lmp change

21c3593

change lmp for the delivey form to appear in care guides

6d64f55

create facility, area and supervisor

aa566b4

add create chw user

80ee2d4

adjust sizes for Message tab name to fit

d1116f8

organize test in suites

b890dcd

fix eslint

33344cd

remove updateRolePermissions and integrate its logic into updatePermi…

e819884

…ssions

replace colons (:) with dashes and remove "local" for clarity

128f717

Co-authored-by: Jennifer Q <[email protected]>

use single quotes instead of template quotes for non-concatenated str…

4743ba3

…ings Co-authored-by: Jennifer Q <[email protected]>

lorerod and others added 26 commits November 28, 2024 12:17

create function to calculate lmp

b17b9b0

Co-authored-by: Jennifer Q <[email protected]>

move lmp inside function

7d27006

Co-authored-by: Jennifer Q <[email protected]>

use camelCase

eb52fbf

Co-authored-by: Jennifer Q <[email protected]>

avoid splitting the string

47719a0

Co-authored-by: Jennifer Q <[email protected]>

fix sonar

0833898

fix eslint

4b358c1

refactor data generation to evenly distribute kids and adults

f1292df

fix eslint

a68b80a

create menu toggle and screenshot function and make contactsButton se…

099015a

…lector private

explain the pause with a comment

a489874

Co-authored-by: Jennifer Q <[email protected]>

explain the pause with a comment

a181ba7

Co-authored-by: Jennifer Q <[email protected]>

explain the pause with a comment

b9925c8

Co-authored-by: Jennifer Q <[email protected]>

add missing space

3416379

Co-authored-by: Jennifer Q <[email protected]>

calculate name in the return

3fcfbc4

Co-authored-by: Jennifer Q <[email protected]>

remove unnecessary constant definition

2c419dd

Co-authored-by: Jennifer Q <[email protected]>

remove unnecessary constant definitions

c651dbf

Co-authored-by: Jennifer Q <[email protected]>

fix variable name typo

5d534a3

fix eslint

2192e6b

use ageType instead of passing extra variables

60e5946

Co-authored-by: Jennifer Q <[email protected]>

use ageType instead of additional variables

9be7bff

Co-authored-by: Jennifer Q <[email protected]>

use ageType instead of additional variables

ef0d285

Co-authored-by: Jennifer Q <[email protected]>

remove duplication of data in the return

f53b13a

Co-authored-by: Jennifer Q <[email protected]>

remove duplication of data in the return

7d55c2c

Co-authored-by: Jennifer Q <[email protected]>

improve code style

339fb7e

Co-authored-by: Jennifer Q <[email protected]>

do not use ageType to simplify code

66a5390

remove cards that where not used from contact summary templated

0a62975

lorerod force-pushed the 9471-ui-nav-image-test-contact-user-management branch from 4551730 to 0a62975 Compare November 28, 2024 15:25

Maria Lorena Rodriguez Viruel and others added 3 commits November 28, 2024 14:20

fix eslint

7b0ef9e

improve openMoreOptionsMenu to handle already opened menu

3634704

first refactor of contact summary extras code

bdfc6c1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(#9471): ui nav work image replacement - contact and user management #9505

chore(#9471): ui nav work image replacement - contact and user management #9505

lorerod commented Oct 4, 2024 •

edited by github-actions bot

Loading

lorerod commented Oct 11, 2024

latin-panda left a comment

latin-panda left a comment

latin-panda Oct 29, 2024

lorerod Nov 13, 2024 •

edited

Loading

lorerod Nov 13, 2024

latin-panda Oct 29, 2024

latin-panda left a comment

latin-panda left a comment

latin-panda commented Nov 25, 2024

lorerod commented Nov 25, 2024

chore(#9471): ui nav work image replacement - contact and user management #9505

Are you sure you want to change the base?

chore(#9471): ui nav work image replacement - contact and user management #9505

Conversation

lorerod commented Oct 4, 2024 • edited by github-actions bot Loading

Description

Code review checklist

Compose URLs

License

lorerod commented Oct 11, 2024

latin-panda left a comment

Choose a reason for hiding this comment

latin-panda left a comment

Choose a reason for hiding this comment

latin-panda Oct 29, 2024

Choose a reason for hiding this comment

lorerod Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

lorerod Nov 13, 2024

Choose a reason for hiding this comment

latin-panda Oct 29, 2024

Choose a reason for hiding this comment

latin-panda left a comment

Choose a reason for hiding this comment

latin-panda left a comment

Choose a reason for hiding this comment

latin-panda commented Nov 25, 2024

lorerod commented Nov 25, 2024

lorerod commented Oct 4, 2024 •

edited by github-actions bot

Loading

lorerod Nov 13, 2024 •

edited

Loading