-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9269): pass last three months target docs to contact summary #9394
Conversation
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Hi @latin-panda This became sort of urgent https://medic.slack.com/archives/C044NKVMD4Z/p1725011773530029?thread_ts=1724962197.807179&cid=C044NKVMD4Z |
cc @lorerod Appreciate it! |
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
@dianabarsan, is this feature only applicable to online users? |
@lorerod no, it's applicable for all users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @diana. This looks great. I just left a couple of suggestions, but none are a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dianabarsan! ✨
Mostly minor suggestions, and a couple of questions where I didn't fully understand
Just curious: do you think this will make the contact details page slower? Something we need to monitor? |
It does add a two extra queries. I had performance in mind when I designed this and rewrote it three times until I was satisfied. |
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🤩 Ship it 🛫
oh, if you haven't already, remember to document it in cht-docs
…9394) Adds new analytics property to CHTDatasourceAPI in webapp. This analytics property gets a targetDocs() list passed to contact-summary. This list has the latest 3 target docs for the contact. When generating the contact summary of one of the logged in user's facilities, pass the logged in user's target docs to contact-summary. #9269 (cherry picked from commit bbe5ded)
…9394) Adds new analytics property to CHTDatasourceAPI in webapp. This analytics property gets a targetDocs() list passed to contact-summary. This list has the latest 3 target docs for the contact. When generating the contact summary of one of the logged in user's facilities, pass the logged in user's target docs to contact-summary. #9269 (cherry picked from commit bbe5ded)
Description
Adds new
analytics
property to CHTDatasourceAPI in webapp.This analytics property gets a
targetDocs()
list passed to contact-summary. This list has the latest 3 target docs for the contact.When generating the contact summary of one of the logged in user's facilities, pass the logged in user's target docs to contact-summary.
#9269
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.