Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#308): Add autoverify=true to AndroidManifest.xml file #353

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

sugat009
Copy link
Member

@sugat009 sugat009 commented Mar 27, 2024

This PR contains the changes for auto-verification of the domain with the app for deeplinks. This would only partially fix 308 .

@sugat009 sugat009 added the Type: Bug Fix something that isn't working as intended label Mar 27, 2024
@sugat009 sugat009 linked an issue Mar 27, 2024 that may be closed by this pull request
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM! Just a reminder that we should document (in as much detail as possible) how we tested this functionality and what we learned about the behavior. This can go either here in the PR or just in the issue thread.

@jkuester jkuester removed the request for review from lorerod March 27, 2024 15:50
@jkuester
Copy link
Contributor

@lorerod I removed you from this PR since there is not any change in functionality happening as a result of this (trying to keep unnecessary things off your plate!). This functionality is currently non-operable and un-usable for the user because medic/cht-core#8917 has not been addressed on the cht-core side. The only reason for including this functionality here now in cht-android is because of the high program costs associated with deploying new apk versions. We want to get this baked in now so it can start getting deployed, instead of waiting until we actually need it (which would be too late). When we go to address the cht-core functionality, we will circle back for considerable workflow testing of this functionality.

@sugat009
Copy link
Member Author

🚀 LGTM! Just a reminder that we should document (in as much detail as possible) how we tested this functionality and what we learned about the behavior. This can go either here in the PR or just in the issue thread.

I was planning on writing the steps to test the changes from this PR in the issue itself because another PR for the manual verification and the e2e tests are incoming as well so I wanted to have the test process in one place for future references.

@sugat009 sugat009 merged commit bfbb902 into master Mar 28, 2024
7 checks passed
@sugat009 sugat009 deleted the 308-deep-links-broken-by-default-on-android-12+ branch March 28, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Fix something that isn't working as intended
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Deep links broken by default on Android 12+
2 participants