fix(#338): Refactor OpenSettingsDialogFragment class to have a empty …

…constructor

src/main/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivity.java

@@ -102,7 +102,7 @@ public void onReceiveValue(String result) {
 		container = findViewById(R.id.wbvMain);
 		getFragmentManager()
 			.beginTransaction()
-			.add(new OpenSettingsDialogFragment(container), OpenSettingsDialogFragment.class.getName())
+			.add(new OpenSettingsDialogFragment(), OpenSettingsDialogFragment.class.getName())
 			.commit();
 
 		configureUserAgent();

src/main/java/org/medicmobile/webapp/mobile/OpenSettingsDialogFragment.java

@@ -13,15 +13,16 @@
 
 import java.time.Clock;
 
-@SuppressLint("ValidFragment")
 public class OpenSettingsDialogFragment extends Fragment {
 
-	private final View view;
 	private int fingerTapCount = 0;
 	private long lastTimeTap = 0;
 	private GestureHandler swipeGesture;
 	private static final int TIME_BETWEEN_TAPS = 500;
 
+	public OpenSettingsDialogFragment() {
+	}
+
 	private final OnTouchListener onTouchListener = new OnTouchListener() {
 		@SuppressLint("ClickableViewAccessibility")
 		@Override
@@ -32,13 +33,10 @@ public boolean onTouch(View view, MotionEvent event) {
 		}
 	};
 
-	public OpenSettingsDialogFragment(View view) {
-		this.view = view;
-	}
-
 	@Override
 	public void onCreate(@Nullable Bundle savedInstanceState) {
 		super.onCreate(savedInstanceState);
+		View view = getActivity().findViewById(R.id.wbvMain);
 		view.setOnTouchListener(onTouchListener);
 	}
 

src/test/java/org/medicmobile/webapp/mobile/OpenSettingsDialogFragmentTest.java

@@ -49,11 +49,12 @@ public void setup() {
 		doNothing().when(view).setOnTouchListener(argsOnTouch.capture());
 
 		MockSettings fragmentSettings = withSettings()
-			.useConstructor(view)
+			.useConstructor()
 			.defaultAnswer(CALLS_REAL_METHODS);
 
 		openSettingsDialogFragment = mock(OpenSettingsDialogFragment.class, fragmentSettings);
 		when(openSettingsDialogFragment.getActivity()).thenReturn(activity);
+		when(openSettingsDialogFragment.getActivity().findViewById(R.id.wbvMain)).thenReturn(view);
 		argsStartActivity = ArgumentCaptor.forClass(Intent.class);
 		doNothing().when(openSettingsDialogFragment).startActivity(argsStartActivity.capture());