Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'What is a PWA' guide #26569
Add 'What is a PWA' guide #26569
Changes from 16 commits
e03308c
543df05
1f2729a
44e593d
f29e56e
9a3e1fb
1fbfd44
11c6d1d
3c90851
273e79c
3c9521b
791a44c
dcf8c15
03dc0ac
70dca9c
e57351a
aab0806
91eb79d
455d731
eda2b4e
d5a923b
d77ee1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be too basic for other pages, but this is a very intro article so we likely want to let them know how to install a PWA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be good to think of total beginners here and also explain how PWAs actually run. This section clearly explains the benefits of both worlds, but I think the missing piece is understanding that a PWA, even if it looks like a standalone app, still runs in the browser. It's the browser that installs it in the OS, and it's the browser that runs it eventually, even if it may not look like it to the end user.
I think this is important because we very often talk about the browser when talking about PWAs, without really saying why. And as a beginner, or someone coming from a native app background, that might feel weird since we focus so much on building "real" apps that are totally standalone. They might ask themselves: But why do they keep referring to the browser, I only see my app?
In fact, just below, on line 64, we say that the manifest is useful for the browser to install the PWA. So explaining the relationship between the browser and a PWA before that would help clarify this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this section. This is very helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would personally remove "it's obvious" here. I know it's not what you meant, but it's the sort of phrase I associate with "basic", or "simple" which I tend to stay away from to avoid making assumptions about the reader's level of expertise/understanding of a concept.
Maybe something like:
"When you visit a website in the browser, that website is visible within the UI of the browser, which displays a frame around it with features like back/forward buttons and a title for the page. The source code of the website, and the Web APIs it uses all run in the browser engine."
I would also get rid of "The browser provides a kind of virtual machine for executing the website's code" which I don't think adds much value on top of what's already been said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point about "obvious". But I like the idea that you can see it's "running in the browser". Would you be OK with something like:
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to slightly rephrase "This means they need a browser engine, like Chrome or Firefox, to manage and run them"
"This means they need a browser engine, like the ones in Chrome, Firefox, or Safari, to manage and run them."
Just to make the distinction between browser, browser UI, and browser engine even clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can change the heading to "Progressive enhancement and graceful degradation."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great diagram. This helps a lot.