-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shadowroot to shadowrootmode #18855
shadowroot to shadowrootmode #18855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did any renaming also happen for the IDL reflected property or is there none?
Yes, there is now an IDL reflected property |
One more note about that - neither of these was "useful" for anything other than feature detection of declarative Shadow DOM. Setting the |
Thanks @mfreed7! This PR looks fine as is but I guess it would be great to follow up on the other changes that got made related to this. |
Right - the declarative shadow DOM spec PR (whatwg/html#5465) hasn't yet landed. It's held up on one last issue, whatwg/html#8759. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointers! Going to merge this one. We will likely follow-up with the new additions soon then.
In Chrome 111 the
shadowroot
attribute for<template>
has been renamed toshadowrootmode
to match the updated spec.I've updated BCD here, making
shadowroot
an alternative name, and I'll add updating the docs to our worklist.https://chromestatus.com/feature/5161240576393216