feat: added min/max font scale option

mbret · Aug 24, 2024 · 3821bda · 3821bda
1 parent 83bbc4a
commit 3821bda
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/packages/enhancer-gestures/src/SettingsManager.ts b/packages/enhancer-gestures/src/SettingsManager.ts
@@ -9,9 +9,11 @@ export class GesturesSettingsManager extends SettingsManager<InputSettings, Outp
   getDefaultSettings(): InputSettings {
     return {
       panNavigation: "pan",
+      pinchCancelPan: true,
       fontScalePinchEnabled: true,
       fontScalePinchThrottleTime: 500,
-      pinchCancelPan: true,
+      fontScaleMaxScale: 5,
+      fontScaleMinScale: 0.2,
     }
   }
 }
diff --git a/packages/enhancer-gestures/src/gestures/pinch.ts b/packages/enhancer-gestures/src/gestures/pinch.ts
@@ -89,8 +89,15 @@ export const registerPinch = ({
                   trailing: true,
                 }),
                 tap((event) => {
+                  const newScale = parseFloat((lastFontScaleOnPinchStart + (event.scale - 1)).toFixed(2))
+
+                  const newMinMaxedFontScale = Math.max(
+                    Math.min(newScale, settingsManager.values.fontScaleMaxScale),
+                    settingsManager.values.fontScaleMinScale,
+                  )
+
                   reader.settings.update({
-                    fontScale: parseFloat((lastFontScaleOnPinchStart + (event.scale - 1)).toFixed(2)),
+                    fontScale: newMinMaxedFontScale,
                   })
                 }),
                 takeUntil(pinchEnd$),

diff --git a/packages/enhancer-gestures/src/types.ts b/packages/enhancer-gestures/src/types.ts
@@ -15,6 +15,11 @@ export type GestureEvent = ObservedValueOf<GestureRecognizable["events$"]>
 export type InputSettings = {
   panNavigation: "pan" | "swipe" | false
   fontScalePinchEnabled: boolean
+  fontScaleMaxScale: number
+  fontScaleMinScale: number
+  // @todo default value
+  // @todo font scale max / min
+  // @todo cancel pan if selecting
   fontScalePinchThrottleTime: number
   pinchCancelPan: boolean
 }