Improve time and memory parsing and allow environment variables for common options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
The memory parsing has improved, especially for larger values. Previously, 1.5T would get rounded up to 2TB, which was annoying! Now anything larger than 1M is round to the nearest megabyte and passed to sbatch as megabytes to keep precisio, so now
-m 1.5tis passed to sbatch as 1500000M.The time parsing has also improved a little, with the notable difference being that passing a value with no unit
-t 3is passed straight to sbatch, which will use minutes by default. Previously we would have set this to 3 seconds.Lastly, you can now set the environment variables
SSUBMIT_TIME,SSUBMIT_MEMORY,SSUBMIT_SHEBANG, andSSUBMIT_SETfor their respective options. This is handy for setting a ssubmit default rather than having to enter it on the command line each time.