Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AP start/stop events #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jpasqua
Copy link

@jpasqua jpasqua commented Dec 18, 2020

Add two new values to wifi_config_event_t: WIFI_CONFIG_AP_START and WIFI_CONFIG_AP_STOP

When wifi_config_init2() is used and the client has provided a callback, it will be invoked when the library enters and exits AP mode. This allows the client to give the user some sort of feedback (e.g. blink an LED) that an action needs to be taken.

@maximkulkin
Copy link
Owner

Could you change commit title to "Add AP start/stop events".

Also, usually things like .DS_Store, your IDE files or environment related things is better to have in machine global .gitignore: just create .gitignore in your home directory and then run git config --global core.excludesfile '~/.gitignore'

@jpasqua jpasqua changed the title Add event notifications when ap_mode is entered/exited Add AP start/stop events Dec 18, 2020
@jpasqua
Copy link
Author

jpasqua commented Dec 18, 2020

Title changed. Agreed on .gitignore. Do you want me to do something about it w.r.t. this pull request, or will you just not integrate it?

@maximkulkin
Copy link
Owner

I think we can remove that commit. Otherwise LGTM. Thank you

@maximkulkin
Copy link
Owner

Title changed

@jpasqua Oh, that's not what I meant. I mean, change title of that particular commit, not the title of PR. I still see commit saying "Add additional event types" which might be confusing to see in the history in the long run.

The client can now be notified when the library goes into station mode. This is useful if it wants to display some indication to the user. The client will also be notified when station mode is turned off.
@jpasqua
Copy link
Author

jpasqua commented Apr 5, 2021

Let me know if this looks OK now. I've been using my forked version and forgot about this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants