Remove MAVLink gimbal v1 protocol #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's time to sunset the old gimbal v1 protocol and simplify the gimbal plugin implementation around v2. The auto-detection between v1 and v2 had quite a few problems, so it was hurting us.
This is better covered by the gimbal plugin.
julianoes
force-pushed
the
pr-remove-gimbal-v1
branch
from
336a805
to
e64553a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time to sunset the old gimbal v1 protocol and simplify the gimbal plugin implementation around v2. The auto-detection between v1 and v2 had quite a few problems, so it was hurting us.
Depends on mavlink/MAVSDK-Proto#350.
Closes #2317.
Still todo: implement gimbal manager information message.Fix it in a follow up PR.