New audio! #335
Open
New audio! #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mattgodbolt
commented
Dec 22, 2021
•
mattgodbolt
commented
- Outputs audio at chip frequency
- Spits it out as buffers to a web audio thread that then (terribly) downsamples it.
- Various queues and stats
- Horrible hacks to try and keep things in sync.
mattgodbolt
changed the title
This reverts commit 58642bd. It was not good enough - averaging works better to reduce noise on e.g. depeche mode.
8bitkick
reviewed
Feb 26, 2024
| new AudioWorklet( | ||
| new URL("./audio-renderer.js", import.meta.url) | ||
| ) | ||
| ); | ||
| if (audioFilterFreq !== 0) { | ||
| this.soundChip.filterNode = this.audioContext.createBiquadFilter(); | ||
| this.soundChip.filterNode.type = "lowpass"; | ||
| this.soundChip.filterNode.frequency.value = audioFilterFreq; | ||
| this.soundChip.filterNode.Q.value = audioFilterQ; |
There was a problem hiding this comment.
For a cleaner separation of web API I/O vs pure emulation code,filterNode doesn't need to be instanced as a property of soundChip
There was a problem hiding this comment.
(I'm only noticing this due to my weird use case running JSbeeb in a worker)
There was a problem hiding this comment.
Thanks! I think I put it there purely to "hang on to it" as I think in some cases if it gets GC'd maybe it stops working?
|
Webpack's lack of decent support still gives me pause, but...I brought this up to date at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.