Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sgxGramineContainer): expose maxLayers argument from image builder #67

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ozwaldorf
Copy link
Contributor

Summary

The current sgxGramineContainer builder uses a lot of layers by itself, not leaving much room for more complex enclaves before hitting a compile time error. Allowing users to adjust the maxLayers parameter is sufficient to solve the issue.

error: builder for '/nix/store/nr78hkr0x4s1rq5xz69yvk3hxgcpqzpy-foobar-manifest-app-conf.json.drv' failed with exit code 1;
       last 1 log lines:
       > Error: usedLayers 101 layers to store 'fromImage' and 'extraCommands', but only maxLayers=100 were allowed. At least 1 layer is required to store contents.

What's changed

  • Exposed the maxLayers argument from dockerTools.buildLayeredImage and uses it throughout the builder in each step

@ozwaldorf ozwaldorf requested a review from a team as a code owner November 13, 2024 18:12
@haraldh
Copy link
Collaborator

haraldh commented Nov 13, 2024

I did the same thing yesterday... 🤣

@haraldh haraldh merged commit 88c0700 into matter-labs:main Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants