-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler:zk): zksolc linking #711
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrq
added
compiler 📟
Issues specific to compiling
feature ➕
Feature item
p0 ⚪
Indicates blocker priority item
p1 🟠
Indicates high priority item
and removed
p0 ⚪
Indicates blocker priority item
labels
Nov 7, 2024
fix(compiler:zk): use `bytecode` method on artifact
Karrq
changed the title
[WIP] feat(compiler:zk): zksolc linking
feat(compiler:zk): zksolc linking
Nov 11, 2024
chore: add 2 more unmaintained advisories
elfedy
previously approved these changes
Nov 15, 2024
Co-authored-by: Federico Rodríguez <[email protected]>
elfedy
approved these changes
Nov 19, 2024
hedgar2017
reviewed
Nov 19, 2024
hedgar2017
requested changes
Nov 19, 2024
hedgar2017
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
missing_libraries
api from fix(zk): properly mark unlinked contract Moonsong-Labs/compilers#40TODO: handle zksolc unlinked bytecodes explicitlyTracked in Supportzksolc link
#723Moved startup migration to happen when executing contractsfix(zk): delay startup migration #731Why ✋
create
and other functionality in foundry are overridden for zksolc to expect bytecode to always be linkedEvidence 📷
Notes 📝
fix(zk): delay startup migration #731chore: perform startup zkEVM storage migration just before test contract execution #732 and fix(deny): instant and derivative are unmaintained #730