Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler:zk): zksolc linking #711

Merged
merged 18 commits into from
Nov 20, 2024
Merged

feat(compiler:zk): zksolc linking #711

merged 18 commits into from
Nov 20, 2024

Conversation

Karrq
Copy link
Contributor

@Karrq Karrq commented Nov 7, 2024

What 💻

Why ✋

  • should have been done as part of feat(compiler:zk): zksolc 1.5.7 #688
  • we now always expect it to be present, and to be near the corresponding bytecode
  • create and other functionality in foundry are overridden for zksolc to expect bytecode to always be linked
  • Initial migration was inconsistent due to different usages of the executors within foundry

Evidence 📷

Screenshot 2024-11-11 at 16 15 55

Notes 📝

@Karrq Karrq self-assigned this Nov 7, 2024
@Karrq Karrq added compiler 📟 Issues specific to compiling feature ➕ Feature item p0 ⚪ Indicates blocker priority item p1 🟠 Indicates high priority item and removed p0 ⚪ Indicates blocker priority item labels Nov 7, 2024
@Karrq Karrq mentioned this pull request Nov 11, 2024
@Karrq Karrq changed the title [WIP] feat(compiler:zk): zksolc linking feat(compiler:zk): zksolc linking Nov 11, 2024
@Karrq Karrq marked this pull request as ready for review November 11, 2024 15:16
@Karrq Karrq requested a review from a team as a code owner November 11, 2024 15:16
@Karrq Karrq requested a review from nbaztec November 15, 2024 13:56
elfedy
elfedy previously approved these changes Nov 15, 2024
crates/forge/bin/cmd/create.rs Outdated Show resolved Hide resolved
crates/forge/src/multi_runner.rs Outdated Show resolved Hide resolved
crates/forge/tests/it/zk/linking.rs Outdated Show resolved Hide resolved
crates/script/src/build.rs Outdated Show resolved Hide resolved
deny.toml Outdated Show resolved Hide resolved
crates/cheatcodes/src/inspector.rs Outdated Show resolved Hide resolved
Co-authored-by: Federico Rodríguez <[email protected]>
@Karrq Karrq requested a review from elfedy November 18, 2024 09:33
@Karrq Karrq merged commit f51b213 into main Nov 20, 2024
13 checks passed
@Karrq Karrq deleted the feat/zksolc-link branch November 20, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler 📟 Issues specific to compiling feature ➕ Feature item p1 🟠 Indicates high priority item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants