Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add non-inlinable libraries section #32

Merged
merged 3 commits into from
Oct 18, 2024
Merged

feat: Add non-inlinable libraries section #32

merged 3 commits into from
Oct 18, 2024

Conversation

elfedy
Copy link
Collaborator

@elfedy elfedy commented Oct 14, 2024

Bring back comments about dealing with non-inlinable libraries that were lost when replacing README in foundry-zksync with links to the book.

tomimor
tomimor previously approved these changes Oct 14, 2024
Copy link
Collaborator

@tomimor tomimor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! My only suggestion would be to consider whether it fits better under the Limitations section rather than as a general section in the ZKsync specifics.

@elfedy elfedy merged commit 2b86f6f into main Oct 18, 2024
3 checks passed
@elfedy elfedy deleted the elfedy-nilibs branch October 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants