Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update config api reference #412

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: update config api reference #412

merged 1 commit into from
Nov 25, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

What 💻

This PR fixes the config API reference in SUPPORTED_APIS.md

Why ✋

Commit 28cad46 renamed src/node/config.rs to be src/node/config_api.rs

Evidence 📷

@emmanuel-ferdman
fix: update config api reference
fc3cfd6 
Signed-off-by: Emmanuel Ferdman <[email protected]>
@emmanuel-ferdman emmanuel-ferdman requested a review from a team as a code owner November 23, 2024 11:52
@popzxc popzxc requested a review from itegulov November 25, 2024 06:56
@popzxc
Copy link
Member

popzxc commented Nov 25, 2024

@itegulov PTAL

itegulov
itegulov approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not sure how valuable it is to maintain these in general but not broken links are definitely better than broken ones

@itegulov itegulov merged commit 427f814 into matter-labs:main Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itegulov itegulov itegulov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmanuel-ferdman @popzxc @itegulov