Update default l1 gas price value, add CLI arg #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What π»
Why β
With the l1 gas price of 50 gwei, the gas price per pubdata is 17 * 5010^9 / 250000000 = 3400. It means that we can publish only 8010^6 / 3400 ~ 23529 bytes of the pubdata in one tx(with 80*10^6 gas limit). That's definitely not enough for the tests, usually, contracts are bigger. Also, the possible solution was to increase the gas limit instead, as I know, that's allowed to have a bigger gas limit when the gas is spent on the pubdata, but it can cause issues when the transaction wants to spend more on computation. I think it makes sense to think about it when the gas limit estimation will be implemented.