Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the new API for factory deps #213

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

hedgar2017
Copy link
Collaborator

What ❔

Adds the support for linking factory dependencies for EraVM.

Why ❔

Contracts with unlinked libraries are not ready for deployment, and they cannot have the bytecode hash either.
It means that we need to link EraVM in two iterations: libraries first, factory dependencies later.

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@hedgar2017 hedgar2017 marked this pull request as draft November 25, 2024 08:30
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 93.40278% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (c5f34a1) to head (185905d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/evmla/ethereal_ir/function/block/element/mod.rs 68.00% 8 Missing ⚠️
...l/parser/statement/expression/function_call/mod.rs 0.00% 6 Missing ⚠️
era-compiler-solidity/src/build_eravm/mod.rs 95.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   72.71%   72.63%   -0.09%     
==========================================
  Files         133      132       -1     
  Lines       15369    15363       -6     
==========================================
- Hits        11176    11159      -17     
- Misses       4193     4204      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hedgar2017 hedgar2017 force-pushed the az-link-factory-dependencies branch 2 times, most recently from 9f3fe97 to d486b6e Compare November 29, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant