-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use the new API for factory deps #213
Draft
hedgar2017
wants to merge
10
commits into
main
Choose a base branch
from
az-link-factory-dependencies
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
from
November 26, 2024 15:16
5aeff93
to
fa60c04
Compare
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
from
November 26, 2024 17:19
bde18c9
to
396e212
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 72.71% 72.63% -0.09%
==========================================
Files 133 132 -1
Lines 15369 15363 -6
==========================================
- Hits 11176 11159 -17
- Misses 4193 4204 +11 ☔ View full report in Codecov by Sentry. |
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
from
November 27, 2024 06:46
70a696f
to
5ece679
Compare
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
from
November 27, 2024 07:06
5ece679
to
e281869
Compare
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
2 times, most recently
from
November 29, 2024 13:14
9f3fe97
to
d486b6e
Compare
hedgar2017
force-pushed
the
az-link-factory-dependencies
branch
from
November 29, 2024 13:39
d486b6e
to
2f25853
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds the support for linking factory dependencies for EraVM.
Why ❔
Contracts with unlinked libraries are not ready for deployment, and they cannot have the bytecode hash either.
It means that we need to link EraVM in two iterations: libraries first, factory dependencies later.
Checklist
cargo fmt
and checked withcargo clippy
.