Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move code segment to era-compiler-common #51

Merged
merged 1 commit into from
Nov 1, 2024
Merged

chore: move code segment to era-compiler-common #51

merged 1 commit into from
Nov 1, 2024

Conversation

hedgar2017
Copy link
Collaborator

What ❔

Moves contract code segment to era-compiler-common.

Why ❔

It is required for some LLVM-independent crates such as the upcoming era-solc client.

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

PavelKopyl
PavelKopyl approved these changes Nov 1, 2024
View reviewed changes
Copy link

@PavelKopyl PavelKopyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hedgar2017 hedgar2017 merged commit 5350b28 into main Nov 1, 2024
@hedgar2017 hedgar2017 deleted the az-move-code-segment branch November 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelKopyl PavelKopyl PavelKopyl approved these changes

@sayon sayon Awaiting requested review from sayon

@antonbaliasnikov antonbaliasnikov Awaiting requested review from antonbaliasnikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedgar2017 @PavelKopyl