Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add advanced cargo checks including fmt, clippy, and audit #14

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

Add advanced cargo checks: fmt, clippy, udeps (unused dependencies), audit

Checklist

  • PR title corresponds to the body of PR.
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via cargo fmt and checked with cargo clippy.

@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review June 24, 2024 11:06
@antonbaliasnikov
Copy link
Contributor Author

@hedgar2017 , could you, please, also remove TruffleHog from mandatory checks for this repo?

@hedgar2017
Copy link
Collaborator

@hedgar2017 , could you, please, also remove TruffleHog from mandatory checks for this repo?

It was added by Devops/Infosec.
Could you outline why we should remove it?

@hedgar2017 hedgar2017 merged commit 6a8f58a into main Jun 24, 2024
2 checks passed
@hedgar2017 hedgar2017 deleted the aba-add-cargo-checks branch June 24, 2024 12:45
@hedgar2017
Copy link
Collaborator

@hedgar2017 , could you, please, also remove TruffleHog from mandatory checks for this repo?

It's quite useful to find unwanted stuff in commited code.
It's probably just broken and we should check out why.

@antonbaliasnikov
Copy link
Contributor Author

@hedgar2017 , could you, please, also remove TruffleHog from mandatory checks for this repo?

It's quite useful to find unwanted stuff in commited code. It's probably just broken and we should check out why.

We still have this check, but the repository requirement is not properly configured requiring it to be a job. I explained it in the other PR some time ago, can't find it. It can set it up, but with admin permissions only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants