Add "--use-http-x-forwarded-for" option for NGINX #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the script to pick up an ip address from the `http_x_forwarded_for` field instead of the `ip` field in NGINX JSON formatted log file provided that the "--use-http-x-forwarded-for" option is used. If the `http_x_forwarded_for` field contains "-" or is missing, the script will pick up the ip address from the `ip` field. This option is useful if the `ip` field does not contain client's ip address (e.g. using NGINX as a reverse proxy). Updated README file to include a field `http_x_forwarded_for` in NGINX log file and information about the usage of "--use-http-x-forwarded-for" option. Added two test cases to test the "--use-http-x-forwarded-for" option to ensure that the script works properly.
|
@adityapahuja Thank you! That helped me. |
kutovoys
suggested changes
Jul 30, 2022
| @@ -891,6 +900,11 @@ def _create_parser(self): | |||
| default=False, | |||
| help="Do not verify the SSL / TLS certificate when contacting the Matomo server. This is the default when running on Python 2.7.8 or older." | |||
| ) | |||
| option_parser.add_option( | |||
There was a problem hiding this comment.
For new versions it will be
parser.add_argument(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
http_x_forwarded_forfield instead of theipfield in NGINX JSON formatted log file provided that the "--use-http-x-forwarded-for" option is used. If thehttp_x_forwarded_forfield contains "-" or is missing, the script will pick up the ip address from theipfield. This option is useful if theipfield does not contain client's ip address (e.g. using NGINX as a reverse proxy).http_x_forwarded_forin NGINX log file and information about the usage of "--use-http-x-forwarded-for" option.This feature is useful for replaying requests coming from NGINX reverse proxy to Matomo.