Fix and improve negative binomial distribution #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the rate parameter of the gamma distribution used to represent the negative binomial distribution as Poisson mixture.
…ution Make the unchecked sample methods of the Poisson distribution internal instead of private. Within the negative binomial sampling, call the Poisson sample method instead of duplicating the implementation.
The negative binomial distribution is undefined for p = 0 (asymptotically, it reaches infinity, which cannot be represented as integer). This also avoids unhandled divisions by 0 or other undefined mathematical operations in the properties and an endless loop in the sampling method.
Use correct XML encoding of the less than operator for the description of the range of the p parameter.
Adjust the unit tests after parameter restriction and proper handling of edge cases: - Use p = 0.1 instead of p = 0.0 - Add a test case with p = 0.0 in test for invalid parameters - Add special case in probability validation for p = 1.0 and r = 0.0
|
Hello @cdrnet, |
|
Please ignore CodeQL - I've removed it on master in the meantime. |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #455, #320 and the remainder of #263.