Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line ending handling in reverse_readfile/readline across OS, and not skipping empty lines #712

Open
wants to merge 100 commits into
base: master
Choose a base branch
from
Open

Fix line ending handling in reverse_readfile/readline across OS, and not skipping empty lines #712

wants to merge 100 commits into from

Commits on Sep 4, 2024

  1. add l_end arg to reverse_readfile

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e2952c4 View commit details
    Browse the repository at this point in the history

  2. rstrip remove hard coded trailing white space

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    619a38d View commit details
    Browse the repository at this point in the history

  3. add default value for l_end

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6cbea60 View commit details
    Browse the repository at this point in the history

  4. add l_end to reverse_readline

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0de9696 View commit details
    Browse the repository at this point in the history

  5. continue CI test jobs upon failure

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f114afe View commit details
    Browse the repository at this point in the history

  6. bump codecov to v4

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    deb1ad7 View commit details
    Browse the repository at this point in the history

  7. tweak docstring

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c4a845c View commit details
    Browse the repository at this point in the history

  8. var name and docstring tweak

    @DanielYang59
    DanielYang59 committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    afbe573 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. add helper function to get line ending and unit test

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a4c4fe3 View commit details
    Browse the repository at this point in the history

  2. add bzip2 and gzip file support and test

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    86ea01b View commit details
    Browse the repository at this point in the history

  3. sort import and tweak docstring

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c7ec2de View commit details
    Browse the repository at this point in the history

  4. use unix line ending \n as default if empty

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ae125c3 View commit details
    Browse the repository at this point in the history

  5. fix docstring

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    343e0db View commit details
    Browse the repository at this point in the history

  6. update unit test

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d288e0d View commit details
    Browse the repository at this point in the history

  7. remove accidental comment sign

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    064c064 View commit details
    Browse the repository at this point in the history

  8. use if after return

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    30624aa View commit details
    Browse the repository at this point in the history

  9. tweak docstring

    @DanielYang59
    DanielYang59 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3084123 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. reset pointer to fix test in windows

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1639725 View commit details
    Browse the repository at this point in the history

  2. encode in linux

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    dfe553d View commit details
    Browse the repository at this point in the history

  3. reset pointer in win only

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    3b7a811 View commit details
    Browse the repository at this point in the history

  4. yield str in windows

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b291707 View commit details
    Browse the repository at this point in the history

  5. use Iterator as return type

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    aeba5a7 View commit details
    Browse the repository at this point in the history

  6. assert iterator return str

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1d7adda View commit details
    Browse the repository at this point in the history

  7. strict usage of rstrp(line_ending)

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e6312a6 View commit details
    Browse the repository at this point in the history

  8. better assert no error

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7911e0a View commit details
    Browse the repository at this point in the history

  9. decode before strip, but tests are failing

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6cb5349 View commit details
    Browse the repository at this point in the history

  10. add test_file_with_empty_lines for readfile, Win still not working

    @DanielYang59
    DanielYang59 committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    79f07f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. allow zipped file directly into get_line_end, and add test

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    d2ea989 View commit details
    Browse the repository at this point in the history

  2. remove seemingly unused file

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6803c7b View commit details
    Browse the repository at this point in the history

  3. update test file to include line end for the last line

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    351452a View commit details
    Browse the repository at this point in the history

  4. skip the first match of line ending char

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6f8baf9 View commit details
    Browse the repository at this point in the history

  5. fix test for zipped format

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    74a451f View commit details
    Browse the repository at this point in the history

  6. drop test for legacy MacOS \r

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ef454b3 View commit details
    Browse the repository at this point in the history

  7. make capture of mmap valueerror more narrow

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3516c27 View commit details
    Browse the repository at this point in the history

  8. use platform.system for windows check

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5e1344c View commit details
    Browse the repository at this point in the history

  9. WIP: test for \r\n is failing for some reason

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    283a383 View commit details
    Browse the repository at this point in the history

  10. fix \r\n location, but it looks silly, need opt

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ace9264 View commit details
    Browse the repository at this point in the history

  11. add TODO tag

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9e92bb9 View commit details
    Browse the repository at this point in the history

  12. finally fixed, avoid newline otherwise \n get overwrite by \r\n causi… 

    …ng double \r
    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6a8f8b5 View commit details
    Browse the repository at this point in the history

  13. fix line ending for text mode

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f69c205 View commit details
    Browse the repository at this point in the history

  14. drop test of \r altogether

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    28e6cc4 View commit details
    Browse the repository at this point in the history

  15. remove manual counter

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bf3b90a View commit details
    Browse the repository at this point in the history

  16. copy unit test, to be fixed

    @DanielYang59
    DanielYang59 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a03b301 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. update warn msg upon empty file

    @DanielYang59
    DanielYang59 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    138b756 View commit details
    Browse the repository at this point in the history

  2. tweak docstring

    @DanielYang59
    DanielYang59 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    29dc50d View commit details
    Browse the repository at this point in the history

  3. add comments

    @DanielYang59
    DanielYang59 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8f94964 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Fix line ending handling in reverse readline

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3804727 View commit details
    Browse the repository at this point in the history

  2. significantly increase test

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    76c0243 View commit details
    Browse the repository at this point in the history

  3. add warning for overly small mem size

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    3b68d14 View commit details
    Browse the repository at this point in the history

  4. update unit test

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cd3bbd1 View commit details
    Browse the repository at this point in the history

  5. add test for illegal usage

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    36a02f4 View commit details
    Browse the repository at this point in the history

  6. use tuple for instance check for now

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    6457922 View commit details
    Browse the repository at this point in the history

  7. avoid repeated len(l_end) call

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    14dad79 View commit details
    Browse the repository at this point in the history

  8. tweak unit test names

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    306a8f1 View commit details
    Browse the repository at this point in the history

  9. supress newline convert

    @DanielYang59
    DanielYang59 committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    168bc42 View commit details
    Browse the repository at this point in the history

  10. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    dcdfde5 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. support bufferedreader and clarify m_file type

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f255121 View commit details
    Browse the repository at this point in the history

  2. clarify and test missing last l_end char

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    57157ef View commit details
    Browse the repository at this point in the history

  3. clean up docstring

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4276032 View commit details
    Browse the repository at this point in the history

  4. clarify myth around blk size and max mem

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    33257c5 View commit details
    Browse the repository at this point in the history

  5. fix skip last l_end (temporarily)

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    f75abd3 View commit details
    Browse the repository at this point in the history

  6. fix skip first l_end match

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    709ed17 View commit details
    Browse the repository at this point in the history

  7. update test big file, but it's failing and need to fix

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    4799c24 View commit details
    Browse the repository at this point in the history

  8. tweak comment

    @DanielYang59
    DanielYang59 committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    702e6ca View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. update TODO list

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    d0a0fda View commit details
    Browse the repository at this point in the history

  2. fix incorrect buffer refill position

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    5af7145 View commit details
    Browse the repository at this point in the history

  3. suppress OS l_end translate

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    384c231 View commit details
    Browse the repository at this point in the history

  4. suppress unrelated warnings

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    6102263 View commit details
    Browse the repository at this point in the history

  5. check file pointer reset

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    e9c22ed View commit details
    Browse the repository at this point in the history

  6. track benchmark script in case we need it someday

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    0be5a85 View commit details
    Browse the repository at this point in the history

  7. track benchmark script in case we need it someday

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    edfa0cb View commit details
    Browse the repository at this point in the history

  8. Merge branch 'readline-line-ending' of github.com:DanielYang59/monty … 

    …into readline-line-ending
    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    bdda9f8 View commit details
    Browse the repository at this point in the history

  9. simplify test script, make env install manual

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    8714cb4 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'readline-line-ending' of github.com:DanielYang59/monty … 

    …into readline-line-ending
    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c236434 View commit details
    Browse the repository at this point in the history

  11. save test log on wsl2

    @DanielYang59
    DanielYang59 committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    174d940 View commit details
    Browse the repository at this point in the history

  12. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    1f7476e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. also track test file create time

    @DanielYang59
    DanielYang59 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0d2af60 View commit details
    Browse the repository at this point in the history

  2. get obj size as getsize is slow in win

    @DanielYang59
    DanielYang59 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7cddd29 View commit details
    Browse the repository at this point in the history

  3. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0b478dd View commit details
    Browse the repository at this point in the history

  4. update builtin readline test not to read entire file

    @DanielYang59
    DanielYang59 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3053e87 View commit details
    Browse the repository at this point in the history

  5. remove outdated test log

    @DanielYang59
    DanielYang59 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    097ae65 View commit details
    Browse the repository at this point in the history

  6. update test log on windows

    @DanielYang59
    DanielYang59 committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    cf542a8 View commit details
    Browse the repository at this point in the history

  7. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    8dc894e View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. test on Ubuntu 22.04 WSL2

    @DanielYang59
    DanielYang59 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e90da64 View commit details
    Browse the repository at this point in the history

  2. pre-commit auto-fixes

    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    df0288b View commit details
    Browse the repository at this point in the history

  3. remove dup test script

    @DanielYang59
    DanielYang59 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0ea6828 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'readline-line-ending' of github.com:DanielYang59/monty … 

    …into readline-line-ending
    @DanielYang59
    DanielYang59 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8db6bb4 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. clear finished TODO tag

    @DanielYang59
    DanielYang59 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f354756 View commit details
    Browse the repository at this point in the history

  2. tweak var name

    @DanielYang59
    DanielYang59 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    96c9108 View commit details
    Browse the repository at this point in the history

  3. fix missing newline char in comment

    @DanielYang59
    DanielYang59 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e1786ef View commit details
    Browse the repository at this point in the history

  4. guard warning filter with context manager

    @DanielYang59
    DanielYang59 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f90074c View commit details
    Browse the repository at this point in the history

  5. add type annotation

    @DanielYang59
    DanielYang59 committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    27b28a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. put tag into condition branch

    @DanielYang59
    DanielYang59 committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    1cdc75b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. untrack benchmark script and results

    @DanielYang59
    DanielYang59 committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    e4940e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge branch 'master' into readline-line-ending

    @shyuep
    shyuep authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    279cd4c View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. fix typo in test var name

    @DanielYang59
    DanielYang59 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    6613d33 View commit details
    Browse the repository at this point in the history

  2. remove merge issue

    @DanielYang59
    DanielYang59 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3baea3a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into readline-line-ending

    @DanielYang59
    DanielYang59 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    61f4aff View commit details
    Browse the repository at this point in the history

  4. revise comment

    @DanielYang59
    DanielYang59 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f1fd669 View commit details
    Browse the repository at this point in the history

  5. suppress mypy errors

    @DanielYang59
    DanielYang59 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    d70e80e View commit details
    Browse the repository at this point in the history