iconcache: Use desktop_id to lookup GDesktopAppInfo #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkareh
force-pushed
the
iconcache-use-gdesktopapp
branch
from
bc1fa59
to
4150059
Compare
vkareh
changed the title
vkareh
force-pushed
the
iconcache-use-gdesktopapp
branch
from
4150059
to
0b5bca1
Compare
lukefromdc
approved these changes
Apr 14, 2024
vkareh
force-pushed
the
iconcache-use-gdesktopapp
branch
from
0b5bca1
to
1ad7a41
Compare
GTK+ has support for the application ID property. This will allow Marco to reconstruct the path to the desktop spec file and so have access to all internal attributes (e.g. name, icon, etc.)
Looking up GDesktopAppInfo from the GTK Application ID we can get a much better match for the icon and load it at the appropriate scale. This results in matching icons to straneous windows and better looking icons overall.
In systems with bamfdaemon running, windows get this property for finding the dekstop spec file of an application. This can be used to find the defined icon for any application window that reports this attribute and provider much better icon matching.
lukefromdc
force-pushed
the
iconcache-use-gdesktopapp
branch
from
1ad7a41
to
96a4b36
Compare
|
Rebased against master to pick up Travis fix, then force-pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #752 by using either
_BAMF_DESKTOP_FILEor_GTK_APPLICATION_IDto reconstruct the path to the desktop spec file. The effect is that any application that reports either of these property to the window (like many GNOME applications do), and has a matching desktop file, will be picked up correctly and Marco will get the best possible icon for that window.If a desktop ID cannot be found for the window, it moves on to the next matching method, so nothing changes for them.