Rework spot addition and link toggling in BDV views #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keymaps. Goal is to replace them by something better.
This new behaviour tries to encompass all what the 'add spot' and
'add linked spot' do.
If 'A' (the default key binding) is pressed in a zon without a spot,
a new spot is created. If it is pressed within a spot, the viewer
moves to the next frame ('C' to move to the previous one) and the user
can drag around to create a new linked spot there. If the key is
released in a zone without any spots, a new one is created, from the
source spot. If a spot is found near where the mouse is released,
the source spot is linked to this one.
Let's benefit from the fact that we do everything from a behaviour.
This way we also implement what is defined in the 'toggle link' behaviour.
Now all spot addition and link toggling in BDV views are done with the new add or link action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements adds new
Behaviourfor adding new spots and linking to new spots. It supersedes and implement the behaviour of several actions and behaviours at once, in a single key-stroke:add spotactiontoggle linkbehaviouradd and link to spotbehaviourA single key (
Aby default, andCto go backward in time) is used to implement all their features:If there are no spots where the mouse is clicked, a new spot is created, which can be positionned by holding the key and moving the mouse.
If the key is pressed from within a source spot, the viewer moves to the next (or previous for its counterpart binding) time point and offers to create a new spot linked to this source.
Hold and drag to position the new spot. A new spot will be created where the mouse is released, and linked to the source spot.
If a target spot is found near the mouse location when the key is released, it is linked to the source spot. If a link already exists between the two, it is removed.