Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method to tag set utils #302

Merged

Conversation

stefanhahmann
Copy link
Collaborator

This Pull Request adds some convenience methods to TreeUtils and TagSetUtils

@stefanhahmann stefanhahmann self-assigned this Apr 5, 2024
@stefanhahmann stefanhahmann marked this pull request as draft April 5, 2024 23:29
@stefanhahmann stefanhahmann force-pushed the add_new_method_to_tag_set_utils branch from 5b185d1 to e75aafb Compare April 10, 2024 10:57
* Convenience method to retrieve the first spot of a branch spot
* getTagSetNames, which return the names of the tag sets in the model
* getTagValue(), which returns the value of a branchSpot within a specified tag set
* unit tests for the 2 new methods are contained
@stefanhahmann stefanhahmann force-pushed the add_new_method_to_tag_set_utils branch from e75aafb to bdbb56f Compare April 12, 2024 12:59
@stefanhahmann stefanhahmann marked this pull request as ready for review May 17, 2024 08:50
@stefanhahmann stefanhahmann requested review from tinevez and removed request for tinevez May 17, 2024 08:50
Copy link
Contributor

@tinevez tinevez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 method signature change requested

…getFirstSpot() methods

Previously the methods created refs that the caller could not release
@stefanhahmann stefanhahmann merged commit 78eda77 into mastodon-sc:dev May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants