Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge top #249

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Merge top #249

wants to merge 12 commits into from

Conversation

fgrunewald
Copy link
Member

addition to topology for merging multiple topologies

@fgrunewald fgrunewald marked this pull request as ready for review August 3, 2022 12:52
@fgrunewald fgrunewald requested a review from pckroon August 3, 2022 19:48
pckroon
pckroon requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks, and didn't look at the test in too much detail (but they look fine at a glance). Looks good otherwise :)

polyply/src/topology.py Show resolved Hide resolved
polyply/src/topology.py Outdated Show resolved Hide resolved
polyply/src/topology.py Outdated Show resolved Hide resolved
polyply/src/topology.py Outdated Show resolved Hide resolved
polyply/src/topology.py Outdated Show resolved Hide resolved
polyply/src/topology.py Outdated Show resolved Hide resolved
pckroon
pckroon requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@pckroon pckroon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nitpick :)

polyply/src/topology.py
Comment on lines 251 to 252
Note distance restraints are not checked for possibly
Note distance restraints are not checked for possible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pckroon pckroon pckroon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgrunewald @pckroon