improvement: warn on integer columns names #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
reviewed
Nov 29, 2024
marimo/_plugins/validators.py
Outdated
Comment on lines
65
to
66
| if not DependencyManager.pandas.has(): | ||
| return |
There was a problem hiding this comment.
For performance this should be not DependencyManager.pandas.imported(), since df can't be a Pandas dataframe if Pandas is not imported. Importing pandas can take a long time.
mscolnick
commented
Nov 29, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.9.28-dev12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer column names are bad practice and can lead to bugs. Narwhal's doesn't support this (for good reason), so we should try to urge users to fix their dataframes.