Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global column to challenges and implement filtering for the column #1136

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

CollinBeczak
Copy link
Contributor

@CollinBeczak CollinBeczak commented Jul 15, 2024

Related Frontend: maproulette/maproulette3#2382

Resolves: maproulette/maproulette3#2373 & maproulette/maproulette3#2350

This PR adds support for a new column in the challenges table called is_global. The challenges.is_global column represents if a challenge is classified as global, currently a challenge is classified as global if it is wider than 180 degrees (half the maps width) or taller than 90 degrees (half the maps height).

A new .sql file was added to update the global column for challenges that currently exist. This column will also be set when a challenge is created or enters a ready status.

@CollinBeczak CollinBeczak marked this pull request as ready for review July 19, 2024 20:48
@CollinBeczak CollinBeczak force-pushed the add-is_global-column-to-challenges branch from 8ec0d01 to 6da8363 Compare August 11, 2024 21:46
@ljdelight ljdelight self-requested a review August 11, 2024 21:46
@CollinBeczak CollinBeczak marked this pull request as draft August 11, 2024 21:56
@CollinBeczak CollinBeczak marked this pull request as ready for review August 12, 2024 03:52
@CollinBeczak CollinBeczak force-pushed the add-is_global-column-to-challenges branch from 4ce8b96 to b6e8a65 Compare September 4, 2024 00:50
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@CollinBeczak CollinBeczak force-pushed the add-is_global-column-to-challenges branch from 25ec1eb to 7bf3bc0 Compare November 15, 2024 20:06
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "global challenge" Boolean filter to Challenge discovery
2 participants