Fix/remaining issues camera inside terrain

CHANGELOG.md

@@ -6,7 +6,9 @@
 - _...Add new stuff here..._
 
 ### 🐞 Bug fixes
+
 - Fix line-placed map-pitch-aligned texts being too large when viewed from some latitudes on a globe ([#4786](https://github.com/maplibre/maplibre-gl-js/issues/4786))
+- Fix crashes when camera is inside terrain. Add padding between camera and surface to prevent cases like this. ([#1542](https://github.com/maplibre/maplibre-gl-js/issues/1542))
 - _...Add new stuff here..._
 
 ## 5.0.0-pre.4

src/ui/camera.test.ts

@@ -2028,6 +2028,9 @@ describe('#flyTo', () => {
         };
         camera.transform = {
             elevation: 0,
+            recalculateZoom: () => true,
+            clone: () => camera.transform,
+            apply: () => {},
             recalculateZoomAndCenter: () => true,
             setMinElevationForCurrentTile: (_a) => true,
             setElevation: (e) => { camera.transform.elevation = e; }

src/ui/camera.ts

@@ -1205,7 +1205,9 @@ export abstract class Camera extends Evented {
     _finalizeElevation() {
         this._elevationFreeze = false;
         if (this.getCenterClampedToGround()) {
-            this.transform.recalculateZoomAndCenter(this.terrain);
+            const tr = this._getTransformForUpdate();
+            tr.recalculateZoomAndCenter(this.terrain);
+            this._applyUpdatedTransform(tr);
         }
     }
 
@@ -1238,13 +1240,14 @@ export abstract class Camera extends Evented {
      *
      * @param tr - The transform to check.
      */
-    _elevateCameraIfInsideTerrain(tr: ITransform) : { pitch?: number; zoom?: number } {
+    _elevateCameraIfInsideTerrain(tr: ITransform): { pitch?: number; zoom?: number } {
         if (!this.terrain && tr.elevation >= 0 && tr.pitch <= 90) {
             return {};
         }
+        const surfacePadding = Math.min(500, 20 * (25 - tr.zoom));
         const cameraLngLat = tr.getCameraLngLat();
         const cameraAltitude = tr.getCameraAltitude();
-        const minAltitude = this.terrain ? this.terrain.getElevationForLngLatZoom(cameraLngLat, tr.zoom) : 0;
+        const minAltitude = this.terrain ? this.terrain.getElevationForLngLatZoom(cameraLngLat, tr.zoom) + surfacePadding : 0;
         if (cameraAltitude < minAltitude) {
             const newCamera = this.calculateCameraOptionsFromTo(
                 cameraLngLat, minAltitude, tr.center, tr.elevation);