Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mapbox/variant.hpp with std::variant #1

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Replace mapbox/variant.hpp with std::variant #1

merged 7 commits into from
Oct 17, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 16, 2024 •
edited
Loading

  • Replaces mapbox/variant.hpp with std::variant.
  • I replaced the macro with explicit code.
  • Adds a test to make sure operator== works as intended for values that hold shared pointers.
  • Now requires C++20.

@cgalvan Could you have a look at this one?

@louwers louwers marked this pull request as ready for review October 17, 2024 10:47
@louwers
Copy link
Collaborator Author

louwers commented Oct 17, 2024

pre-commit.ci run

@louwers louwers merged commit 99ec1d9 into maplibre:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birkskyum birkskyum birkskyum approved these changes

@cgalvan cgalvan cgalvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louwers @cgalvan @birkskyum