Fix CMake config

maplibre · Oct 15, 2024 · 52501a1 · 52501a1
1 parent 2d81938
commit 52501a1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -36,15 +36,18 @@ add_executable(unit-tests ${TEST_SOURCES})
 
 Include(FetchContent)
 
-#https://github.com/catchorg/Catch2/issues/2583
+# SYSTEM property is not propagated so
+# set these globally ¯\_(ツ)_/¯
+# https://gitlab.kitware.com/cmake/cmake/-/issues/25364
 add_compile_options(-Wno-error=conversion)
 add_compile_options(-Wno-error=sign-conversion)
+add_compile_options(-Wno-error=non-virtual-dtor)
 
 FetchContent_Declare(
   Catch2
   GIT_REPOSITORY https://github.com/catchorg/Catch2.git
   GIT_TAG        v3.7.1
-  SYSTEM  # https://gitlab.kitware.com/cmake/cmake/-/issues/25364
+  SYSTEM
 )
 FetchContent_MakeAvailable(Catch2)