Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binja database support #2501

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Binja database support #2501

wants to merge 4 commits into from

Conversation

xusheng6
Copy link
Contributor

@xusheng6 xusheng6 commented Nov 21, 2024 •
edited
Loading

This PR adds support for loading and analyzing a binja database: #2496

There are two things I wish to mention:

  1. This PR is rebased on Various binja backend fixes #2500, rather then the latest master. I now realize this is not the best thing to do, but I cannot simply drop the commits from Various binja backend fixes #2500 because there are conflicts. So maybe first have a look at that PR, and if it gets approved, I can rebase this again (if needed)
  2. I did not add a unit test for this. I know I can save one of the file we use for unit tests to a binja database and then load it. Do you have a representative binary to use for it among those files? Also, should I add a new test or should I just add it to test_binja_features.py?

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xusheng6 @williballenthin