process: simplify string enumeration loop

mandiant · Aug 10, 2023 · 85b58d0 · 85b58d0
1 parent ae9d773
commit 85b58d0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/capa/features/extractors/cape/process.py b/capa/features/extractors/cape/process.py
@@ -44,9 +44,8 @@ def extract_environ_strings(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple
     if not environ:
         return
 
-    for _, value in environ.items():
-        if value:
-            yield String(value), ph.address
+    for value in (value for value in environ.values() if value):
+        yield String(value), ph.address
 
 
 def extract_features(behavior: Dict, ph: ProcessHandle) -> Iterator[Tuple[Feature, Address]]: