Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
outputs
rop: ≈2^42.4, red: ≈2^42.4, δ: 1.012950, β: 40, d: 665, tag: usvp
.This PR will output
rop: ≈2^424.2, red: ≈2^424.2, δ: 1.001567, β: 1413, d: 1621, tag: usvp
.While I refactored NoiseDistribution, I forgot to cast stddev and mean to RR. Oops!
Also: output sparse ternaries as
T(p=p, m=m[, n=n])
because we can?Root cause of the issue: if stddev or mean is not a float type, the PrimalUSVP code
cost_gsa
checks a predicatelhs <= rhs
which is now a Symbolic Expression, causing weird behaviour.