Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmwiedemann
Copy link

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

This patch was done while working on reproducible builds for openSUSE.
@natefinch
Copy link
Member

I like this idea, but passing in a giant opaque number is kind of a horrible UX. Also, all the other environment variables are prefixed with MAGEFILE, so it would at least need to follow that pattern.

I'd be in favor of having MAGEFILE_SOURCE_DATE, which takes an RFC3339 timestamp e.g. "2023-12-20T13:59:59Z" or "2023-12-20T13:59:59-05:00". Then at least the timestamp is human readable and writeable, unlike unix epoch.

@bmwiedemann
Copy link
Author

We could, though that would mean that we need some place where we convert SOURCE_DATE_EPOCH (which we set already anyway for the 100 other tools that use it) into MAGEFILE_SOURCE_DATE.

It would be an improvement over the status quo in either case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants