-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(compile): add trimpath to compile to remove local paths #457
base: master
Are you sure you want to change the base?
refactor(compile): add trimpath to compile to remove local paths #457
Conversation
- Include trimpath to ensure local filepaths from CI or developer don't get included in the produced artifact. - This was added in Go 1.13, so not sure if there is something special to handle adding this flag only if go version > 1.13.
I feel like the EDIT: Ah, I see, that is from #451 and just wasn't removed when making this PR. I'd suggest cleaning that up :D |
My mistake. I did a pr for that but did it on main branch in fork resulting
in my new branch including that. I’ll have to separate this out.
|
@jaredallard reverted back so pr changes are now just this. Not sure about compatibility for prior go versions to 1.13 like I mentioned but otherwise this will be good for privacy. Right now compiled binary includes full path. Cheers |
Co-authored-by: Horacio Duran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me :D
Go documentation on this: