forked from develodesign/magento-gitpod
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream changes #1
Open
johnhughes1984
wants to merge
33
commits into
mage-os:mage-os-mirror
Choose a base branch
from
develodesign:main
base: mage-os-mirror
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added sudo to fix permissions issue * Fix for missing python in lib in new version * Update .gitpod.Dockerfile * Update .gitpod.Dockerfile
* Updated PHP and Magento version .gitpod.Dockerfile * disabled both 2FA modules
* Updated PHP and Magento version .gitpod.Dockerfile * disabled both 2FA modules
* Update .gitpod.yml to improve readability and load times * Reverted init command for installing new Magento instance * Removed name section so command runs after composer install steps * removed task name as process didn't run under this * Cleaned up M2 install script * Moved create db call * Added additional 2FA modules
* Added Cypress support * installed cypress on init command: * added npm install cypress
* Added required Mailpit ports (#17) * Added name and description for Nginx Magento application * Added docker run for starting mailpit * Added mailpit SMTP config to Magento * Update .gitpod.yml named ports
Tested and is all functional, I'll add some instructions on the readme file on how to add the Github secrets for the auth.json in the correct format.
Testing upgrading Magento and services
Fixed ES version
Fixed hardcoded ES version value
Replaced dynamic ES version on build
* Update .gitpod.yml Suppress port open notifications * Ignored ports by default, fixed mailhog failing on restart * Update .gitpod.yml Removed mailpit server port config, only client is useful for users
Reverting ES version increase to get build progressing
Fix percona missing
Ux/port ignore (#21)
Updated to latest security patch
Added ENV to Enable Cache Clean by default
Install Mage Cache Cleaner if required, start if available or close terminal
Remove disabling csp as it's a required module now
Remove duplicate disable command
fix if else syntax and missing ;
Fix typo
await nginx starting
updated to use custom gp sync event
Increased admin session lifetime
Upgrade/php8.3 - Upgrade Magento to 2.4.7-p1 - PHP 8.3 - Mage Cache Cleaner - Elastic search config fix (removed hard coded values) - Increase admin session lifetime - Removed disabling CSP module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.