Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Fixes encoding issues in generated expect script #46

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Fixes encoding issues in generated expect script #46

wants to merge 12 commits into from

Conversation

vStone
Copy link

@vStone vStone commented Feb 8, 2016

We ran into encoding issues when running the installer script. This is an easy fix for the following error.

Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns: /usr/local/android/android-sdk-macosx/tools/android update sdk -u --all -t android-23  
Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns: /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/expect.rb:58:in `match': invalid byte sequence in US-ASCII (ArgumentError)
Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns:    from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/expect.rb:58:in `expect'
Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns:    from /usr/local/android/expect-install-android-23:21:in `block in <main>'
Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns:    from /usr/local/android/expect-install-android-23:15:in `spawn'
Notice: /Stage[main]/Macbin::Android/Android::Platform[android-23]/Android::Package[android-23]/Exec[update-android-package-android-23]/returns:    from /usr/local/android/expect-install-android-23:15:in `<main>'
Error: /usr/local/android/expect-install-android-23 returned 1 instead of one of [0]

Jamie Snape and others added 12 commits December 30, 2015 14:16
Add revision parameter to package and other related defines
e5bbad8 
'present' ensures some revision of the package is installed and does not upgrade
the package when a new version is available.

'<revision number>' ensures that if <revision number> of the package is
installed it is not upgraded. Due to limitations of the android tool, if
<revision number> is not installed, the latest revision will be installed.

Fixes maestrodev#34.

'latest' ensures that the latest revision of the package is installed and
upgrades the package when a new version available.

Fixes maestrodev#26.
Minor documentation fixes
d2695a3
Ensure Android NDK is installed by $android::user
a67c4ca 
Runs the installer as the requested user.

Fixes maestrodev#43.
Fixes and additions to README
91f2844
Add validation of parameters
58eefa3
Fix lint warnings
13837d1
Add support for Debian version 7 and above, Ubuntu 14.10 and above
ba4b2e0
Update inline documentation
944c7be
Add missing tests
cf97701
Check that package exists before trying to install
cfbc98a 
Fixes maestrodev#36.
@vStone
Fixes encoding issues in generated expect script
347f753
@vStone
Merge branch 'pr/45'
7c67017
@mihelich mihelich mentioned this pull request Nov 2, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vStone