Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:(e2e) added test case for mevn info command #141

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

ThakurKarthik
Copy link
Contributor

@ThakurKarthik ThakurKarthik commented Oct 24, 2019

Description

This pr on successful merge adds a test case for mevn info cli command

Addresses #155

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Oct 24, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@ThakurKarthik
Copy link
Contributor Author

@jamesgeorge007 you can review the code ! Thanks.

@jamesgeorge007 jamesgeorge007 added enhancement Enhancement to an existing feature Hacktoberfest Valid for Hacktoberfest-2020 labels Oct 24, 2019
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the e2e approach.

Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the lock file changes.

@ThakurKarthik
Copy link
Contributor Author

@jamesgeorge007 may be the changes are due to some npm issue? I can't revert it back.I can use some help,Thanks !

@jamesgeorge007 jamesgeorge007 removed the Hacktoberfest Valid for Hacktoberfest-2020 label Nov 7, 2019
@jamesgeorge007 jamesgeorge007 force-pushed the test-case-cli branch 4 times, most recently from e771e33 to 36591b5 Compare December 23, 2019 17:57
@jamesgeorge007 jamesgeorge007 changed the title feat: added test case for mevn info command feat:(e2e) added test case for mevn info command Dec 23, 2019
refactor: change let to const

Co-authored-by: Thakur Karthik <[email protected]>
@jamesgeorge007 jamesgeorge007 merged commit a3b8ddf into madlabsinc:develop Dec 23, 2019
@welcome
Copy link

welcome bot commented Dec 23, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants