Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search_htm_ind
caches the name of the index file and its contents in the same global dictionary, and checks whether the dictionary values contain a particular key. Since those values include the actual index contents, this compares the key to the index contents, which is a numpy array. On Numpy 1.2, this raised a warning and returnedFalse
:With Numpy 2.0, however, this is a hard error:
This PR replaces the global dictionary with a caching decorator, making the code simpler, faster, and compatible with Numpy 2.0.