Integrate Weblate into monerujo + remove outdated strings #966
Conversation
Removes strings from translations, where the string was translated and the source string was later changed, but the translation never invalidated May potentially not include all strings, the process to find them was to look into Git Blame and see weird dates and what was changed.
We don't need this, we ignore the MissingTranslation flag. It also means it fallbacks to another variant if available, instead of always being english.
Quick find and replace
Currently translated at 100.0% (368 of 368 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 100.0% (20 of 20 strings) Translation: monerujo/App - Help Translate-URL: https://hosted.weblate.org/projects/monerujo/app-help/pt_BR/
|
@m2049r please do not modify source strings from now on! it's fine if you do but don't change translations! It's better to remove them, maintenance wise. It's IMO easier for us to translate things again than to have to go through every string just to see that something might be wrong, and it becomes confusing because sometimes things can be well... adaptations. If you can get those basic changes that disable linting for MissingTranslation, that would be nice. I still need to figure out how to build to see how things are looking, but it seems OK ATM. These CDATA strings are kind of bad, they show up in a very raw format in Weblate and so the translator still needs to deal with things like \s, weird things like that... |
Updated by "Cleanup translation files" add-on in Weblate. Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/
|
Um... weblate deleted the monerujo project 😀 |
|
@m2049r they restored it ^^ |
Currently translated at 80.0% (4 of 5 strings) Translation: monerujo/App - About Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 80.0% (4 of 5 strings) Translation: monerujo/App - About Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 99.7% (371 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
|
I went over all strings I didn't do, and flagged anything that seemed weird with a comment, will be looking into it in Git history soon to see if it was just an adaptation or if it was a changed string or something |
also changes the link with an engage link instead of a regular project link
Currently translated at 100.0% (5 of 5 strings) Translation: monerujo/App - About Translate-URL: https://hosted.weblate.org/projects/monerujo/app-about/es/
Currently translated at 100.0% (20 of 20 strings) Translation: monerujo/App - Help Translate-URL: https://hosted.weblate.org/projects/monerujo/app-help/es/
Currently translated at 99.7% (371 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 99.7% (371 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
Currently translated at 100.0% (372 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
Currently translated at 100.0% (372 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
|
Hey, @m2049r |
Detected by Weblate
…nt globally AKA strings that were changed on source but not removed from translations, all that
Currently translated at 100.0% (372 of 372 strings) Translation: monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/pt_BR/
|
I think this might be ready to merge! Need to check if everything seems alright, but after that, and being merged, we can point things properly to this repository and after that ask for libre hosting.
|
Squashed commit of the following: commit 65fd465 Author: cardpuncher <[email protected]> Date: Sun Oct 6 10:51:31 2024 +0300 Update help.xml commit 6d5190f Author: cardpuncher <[email protected]> Date: Sun Oct 6 10:38:38 2024 +0300 All errors should have been cleared now Crossing fingers, click & pray. commit 0ae3647 Author: cardpuncher <[email protected]> Date: Sun Oct 6 10:32:00 2024 +0300 Still on it commit f8346a9 Author: cardpuncher <[email protected]> Date: Sun Oct 6 10:29:52 2024 +0300 Error hunting goes on Hopefully there aren't many left. commit 08bf318 Author: cardpuncher <[email protected]> Date: Sun Oct 6 10:11:02 2024 +0300 Squash some syntax errors, there are others commit df9ea45 Author: cardpuncher <[email protected]> Date: Sun Oct 6 09:41:33 2024 +0300 Update French translations and fix a few typos in the process. commit 3ea605f Author: cardpuncher <[email protected]> Date: Sat Oct 5 23:16:56 2024 +0300 Complete Turkish translation commit f04e3dd Merge: abae1f3 3e56d5a Author: cardpuncher <[email protected]> Date: Sat Oct 5 23:15:38 2024 +0300 Merge branch 'm2049r:master' into master commit abae1f3 Author: cardpuncher <[email protected]> Date: Fri Sep 20 12:36:27 2024 +0300 Yet another copy & paste error... :/ commit b1118ae Author: cardpuncher <[email protected]> Date: Fri Sep 20 12:29:17 2024 +0300 Fix a dumb copy & paste error Hopefully this will silence the error. commit 0ae7c8c Author: cardpuncher <[email protected]> Date: Fri Sep 20 12:18:10 2024 +0300 Update French & Turkish translations Mainly for the Sidekick part, also added a few missing strings to the French translation and reverted to use the original "Ledger" word in the Turkish one. Co-authored-by: cardpuncher <[email protected]>
Co-authored-by: Ordtrogen <[email protected]>
| @@ -109,50 +109,6 @@ | |||
| Aquest és el bloc de la cadena de Monero on la vostra transacció ha estat inclosa. | |||
| ]]></string> | |||
|
|
|||
| <string name="help_send"><
There was a problem hiding this comment.
i still don't think we should be losing good translations
There was a problem hiding this comment.
I mean I can just go over and just cherry-pick the barebones, but the reason why I went over with this is that we can't for sure know for every language that they are in fact "good translations"
Changing wording can mean very different things in different languages and affect what gender's used, word position, stuff like that, that's the reason I went over like this, the people who want to make these translations work out will and with Weblate any changes in the future can be easily fixed by translators and not go unnoticed
If you're fine with that, I'll do it
|
if you want, i can look through all translations and remove the non-translated stuff. so this PR would be the barebones of weblate enablement? |
lucasmz-dev
changed the title
Currently translated at 100.0% (372 of 372 strings) Translation: Monerujo/App - Main Translate-URL: https://hosted.weblate.org/projects/monerujo/app-main/es/
https://hosted.weblate.org/projects/monerujo
Being dealt with in a separate branch that we can test everything as safely as possible.
After this is merged, it will be changed to use an automatic GitHub PR + automatic webhooks so that pull is automatic.
Let's see how Weblate behaves with monerujo strings.
Contains #960
Closes #958