Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add argument #207

Closed
wants to merge 7 commits into from
Closed

refactor: add argument #207

wants to merge 7 commits into from

Conversation

lvaudor
Copy link
Owner

@lvaudor lvaudor commented Oct 20, 2023 •
edited
Loading

Fix #206

@lvaudor
Copy link
Owner Author

lvaudor commented Oct 20, 2023

I don't know what I did, I wanted to create a brandnew PR and seem to have incorporated commits from a previous one (???)

@lvaudor lvaudor changed the title replace prefix when not used explicitly in query refactor: add argument Oct 20, 2023
@lvaudor lvaudor marked this pull request as draft October 20, 2023 11:38
@lvaudor lvaudor marked this pull request as ready for review October 20, 2023 11:52
lvaudor
lvaudor commented Oct 20, 2023
View reviewed changes
Copy link
Owner Author

@lvaudor lvaudor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, conflit réglé, mais les checks ci-dessous nous font du rouge pas content...

@maelle
Copy link
Collaborator

maelle commented Oct 20, 2023

In #208 now

@maelle maelle closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pb with replacing prefixes
2 participants
@lvaudor @maelle