-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy Streaming of Tabs #291
Open
jakeatgalileo
wants to merge
52
commits into
lux-org:master
Choose a base branch
from
jakeatgalileo:lazy_stream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
b2563e6
changed button to tab and lazily load widget
381b129
adding tabbing
f851096
removed comments
bcb8917
Merge branch 'master' into lazy_stream
b024cfa
some progress on lazy streaming
f90d5b5
added datetime check for temporal action before processing
2c2a59f
reversed order of actions to put correlation at the back
83a19d2
changed to pushing out tabs as they are done
4c59f84
Merge branch 'master' into lazy_stream
54083b7
debugging intent
bd27bd9
fixed intent bug
693252d
changed tests to use set and fixed bugs
0687fd7
added bakc if statement
f6378ea
updated test due to ordering of tabs
a1e56fd
fixed merge conflicts
bda3c4b
fixed merge conflicts
1d2555e
Merge branch 'master' into lazy_stream
a420a64
added config to turn off streaming, support for greyed tabs
9398896
action logic
1b5c923
changed to pre-displaying tabs
4d2be94
override css
3fe6e68
Merge branch 'master' into lazy_stream
e60ef84
reformatted with black
86d6c91
code cleanup
e61bda7
changed back to repr_html
f772fc7
fixed html
c485d2d
reformatted with black
129d7c8
fixed merge conflicts
593e6b0
some updates
7dd15b2
loadingbar added
a6d05ba
merged into master
a70a9e7
latest commit
b2f272f
Delete communities.csv
jakeatgalileo c60cfc0
Fixed a couple merge conflicts
cc4129b
added in css for pandas
e6c5720
merged into master
f226cca
formatted with black
3ef1f7b
fixed some tests
0c34bb5
updated display
aef50f8
progress on temporal
4d32f1f
fixed pandas coverage tests
45f8330
Merge branch 'master' into lazy_stream
8493b91
progress
00bdf3d
Merge branch 'master' into lazy_stream
07c47ba
fixed last tests
9ce4681
readded output widget for intent button
998086a
updated per comments
5aea05b
reformatted with black
16d2880
fixed merge conflicts
60aab30
fixed loading bar bug
c74b1aa
Merge branch 'master' into lazy_stream
5f0f9c2
ran black
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we currently determine what to compute first v.s. what to compute lazily? Or for now, are we explicitly saying that "correlation" and "geographical" will compute later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, actions are checked in alphabetical order (with correlation being first). I manually put correlation and geographical later because i noticed those two take the longest to compute/render. The order in which we check/compute is very flexible as we can just move the action names around in the list.