-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My attempt at implementing your idea in PR #79 #80
Open
rsforge
wants to merge
16
commits into
lukas-reineke:master
Choose a base branch
from
rsforge:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect you to merge this.
I just thought it might help if you ever find the time to implement your comment from PR #79.
Also, I am not a Lua programmer, or even a Neovim plugin developer for that matter, so take my suggestions with a grain of salt.
You had mentioned "
setup
itself should be callable per buffer.". This is just me taking a crack at it.Here is how you would attach, or setup if you will, locally to a buffer.
When passing config to attach it will figure out the file type you are attaching to. Then use the correct defaults, so long as they have been implemented in by the dev, otherwise it will use a generic set of defaults.
After you have attached it to a buffer, it will automatically refresh when the buffer changes.
You will also notice that I split the code into multiple files. This is just the way I like it.
However, this could easily be changed to fit your style.
Most of the heavy lifting is still being done by your code. I have basically just put a wrapper around it.
I have done some light testing, and so far it seems to work.
If you have any questions, feel free to ask.
And again, I don't expect you to merge this. This is just a quick implementation. That may be useful later on.