Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp to netmap_slot #877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add timestamp to netmap_slot #877

wants to merge 1 commit into from

Conversation

kierank
Copy link
Contributor

@kierank kierank commented Oct 3, 2022

No description provided.

@giuseppelettieri
Copy link
Collaborator

We can't change the size of the slots (ABI break). Maybe we may reuse the ptr field when it is not already used for something else (e.g, offsets). Or, we may use offsets to reserve a place for the ts in the netmap buffer. What do you think?

@kierank
Copy link
Contributor Author

kierank commented Oct 12, 2022

Yes, on mlx5 we do exactly that, use ptr. But we want to start using ice which has ptr being used for offsets.
I'm happy to leave this here for the next ABI change you make because per packet timestamps are useful and now widely available from most modern NICs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kierank @giuseppelettieri