Changed NM_BRIDGES to 256 #421
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added GTAGS to .gitignore and fixed vale port max not 254 issue luigirizzo#398
| @@ -752,8 +751,7 @@ netmap_get_bdg_na(struct nmreq *nmr, struct netmap_adapter **na, | |||
| if (!create) | |||
| return ENXIO; | |||
| /* yes we should, see if we have space to attach entries */ | |||
| needed = 2; /* in some cases we only need 1 */ | |||
| if (b->bdg_active_ports + needed >= NM_BDG_MAXPORTS) { | |||
| if (b->bdg_active_ports >= NM_BDG_MAXPORTS) { | |||
There was a problem hiding this comment.
The previous check was too conservative: >= should have been > and needed should have been computed more precisely.
Your change, however, is wrong. There are cases when we need two slots. See where cand2 is actually used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GTAGS to .gitignore and fixed vale port max not 254 issue #398
To NM_BRIDGES default to 256 because the original default value
8is too small for even test, and
256is OK for hypervisor usage.