-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (G)ARP sender to fix switch broadcast storms #413
Open
markwebster
wants to merge
8
commits into
luigirizzo:master
Choose a base branch
from
markwebster:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Dec 19, 2017
-
pkt-gen: -G for (G)ARP to prevent switch broadcast storms
Needed to maintain {mac:ip} assocation on the switch port. This likely fixes many of the reported pkt-gen issues. Also added PHY link state poll ("auto wait") when '-w0' is specified.
Configuration menu - View commit details
-
Copy full SHA for b705f7b - Browse repository at this point
Copy the full SHA b705f7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bae22b - Browse repository at this point
Copy the full SHA 2bae22bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16f4bb1 - Browse repository at this point
Copy the full SHA 16f4bb1View commit details
Commits on Dec 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b40972c - Browse repository at this point
Copy the full SHA b40972cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06832d3 - Browse repository at this point
Copy the full SHA 06832d3View commit details -
4
Configuration menu - View commit details
-
Copy full SHA for 7dc6dc0 - Browse repository at this point
Copy the full SHA 7dc6dc0View commit details
Commits on Dec 31, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 451452e - Browse repository at this point
Copy the full SHA 451452eView commit details -
Optimised send_packets() check for slots dirtied by ARP packets.
The check is now only done on thread 0, and before touching the slot buffer we check if slot->len == sizeof(ARP packet), ie 42, whereas the smallest packet size pkt-gen does without crashing is 50. (This commit also includes a better minimum packet size constraint for the -l argument). Some related code has been tidied up, and I've added #defines for IPv4 and MAC address sizes (IP4_ALEN, ETH_ALEN) to get rid of some magic numbers.
Configuration menu - View commit details
-
Copy full SHA for 1cbb603 - Browse repository at this point
Copy the full SHA 1cbb603View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.