test: increase test coverage #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kkkaoru
commented
Apr 13, 2024
•
kkkaoru
commented
- increase test coverages
- add a test ci
- add a branch protection
kkkaoru
commented
Apr 13, 2024
Comment on lines
+10
to
+13
| statements: 98.74, | ||
| branches: 81.25, | ||
| functions: 100, | ||
| lines: 98.74, |
There was a problem hiding this comment.
vitest の仕様を正確に把握していないんですが、現在のカバレッジに合わせて設定ファイルも自動で更新されるっぽいです
kkkaoru
commented
Apr 13, 2024
| autoUpdate: true, | ||
| }, | ||
| exclude: ['**/*/index.ts', '**/*/*.types.ts', '**/*/*.d.ts', '**/*/*.js','*.cjs', 'apps', 'src/bin', '**/const/*.*'], |
There was a problem hiding this comment.
カバレッジをいい感じにする為のexclude
kkkaoru
commented
Apr 13, 2024
Comment on lines
-7
to
-42
| export const argsOptions = { | ||
| output: { | ||
| type: 'string', | ||
| multiple: false, | ||
| short: 'o', | ||
| default: './licenses.json', | ||
| }, | ||
| pretty: { | ||
| type: 'boolean', | ||
| multiple: false, | ||
| short: 'p', | ||
| default: false, | ||
| }, | ||
| recursive: { | ||
| type: 'boolean', | ||
| multiple: false, | ||
| short: 'r', | ||
| default: false, | ||
| }, | ||
| dev: { | ||
| type: 'boolean', | ||
| multiple: false, | ||
| short: 'd', | ||
| default: false, | ||
| }, | ||
| 'no-prod': { | ||
| type: 'boolean', | ||
| multiple: false, | ||
| default: false, | ||
| }, | ||
| 'no-optional': { | ||
| type: 'boolean', | ||
| multiple: false, | ||
| default: false, | ||
| }, | ||
| } satisfies ParseArgsConfig['options']; |
There was a problem hiding this comment.
writeLicenses() のテストを書く時にこのファイルの処理が実行されてしまうようだったので、 argsOptions の定義を別ファイルに分けています 🙏
kkkaoru
commented
Apr 13, 2024
Comment on lines
-8
to
-19
| const dirents = await readdir(pnpmPackage.path, { withFileTypes: true }); | ||
| const licenseDirent = dirents.find((dirent) => dirent.name.toLowerCase().includes('license')); | ||
| const licenseDirent = await findLicenseDirent(pnpmPackage.path); | ||
| if (licenseDirent === undefined) { | ||
| return undefined; | ||
| } | ||
| const licenseTxt = await readLicense({ | ||
| name: pnpmPackage.name, | ||
| licensePath: `${pnpmPackage.path}/${licenseDirent.name}`, | ||
| }); | ||
| // remove path property | ||
| const { path, ...PnpmPackageInfo } = pnpmPackage; | ||
| return licenseTxt === undefined ? PnpmPackageInfo : { ...PnpmPackageInfo, licenseTxt }; |
There was a problem hiding this comment.
カバレッジあげるために、処理のファイル分けをするように変更しました
|
@NEKOYASAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.