[dv/dpi] tcpserver single connection and retry select on EINTR #23889
Conversation
Instead of asserting in `client_tryaccept` when a client is already attached, reject the new connection by accepting and immediately closing. Signed-off-by: Kip Walker <[email protected]>
|
heads up @sameo |
| // On interrupt we want to retry; according to the man page | ||
| // the timeout is now undefined. | ||
| timeout.tv_sec = 0; |
There was a problem hiding this comment.
I'm not completely sure about this bit. If I understand the man page correctly, it is just saying that the function might have trashed timeout (see the section called "The timeout").
So I don't think we need to do this change, but we should probably set all of timeout every time, so just need to move the write to tv_sec inside the loop.
There was a problem hiding this comment.
Duh. I've just re-read your change and now I understand what you're doing! I think it would still be much simpler to move this line to appear just before the write to tv_usec. I think the existing code is a bit silly (because timeout.tv_sec might get trashed even if the select call succeeds), but the fix is very easy.
There was a problem hiding this comment.
Thanks for the feedback, I pushed an update.
There was a problem hiding this comment.
(oops, pushed again to remove the now-extraneous initial init of tv_sec).
kwalker27
force-pushed
the
tcpserver-select-retry
branch
from
f93234f
to
26454af
Compare
When select returns -1 and errno is EINTR, the select should just be retried instead of treating it as an error and disconnecting the client. Also move the timeout initialization into the loop right before calling select, since it can get trashed. Signed-off-by: Kip Walker <[email protected]>
kwalker27
force-pushed
the
tcpserver-select-retry
branch
from
26454af
to
c60bfe7
Compare
Two small patches to the
tcp_servercode, used by other transactors such asjtagdpianddmidpi. These improve the usability of the transactors in a shared, remote environment such as an emulator.Without this change, an interrupted select() call is treated as a connection error and the client is dropped. This makes connections very unstable.