[boot_services] Disable OTBN boot services tests that depend on EG's …

…keymgr

With Darjeeling, keymgr is replaced by its DPE version. Both the OTBN
services and the related tests will have to be ported to it. Disable
them for now and only keep the signature verification part.

Signed-off-by: Samuel Ortiz <[email protected]>

sw/lib/sw/device/silicon_creator/otbn_boot_services_functest.c

@@ -6,18 +6,13 @@
 #include "sw/device/lib/testing/test_framework/check.h"
 #include "sw/device/lib/testing/test_framework/ottf_main.h"
 #include "sw/device/silicon_creator/lib/drivers/hmac.h"
-#include "sw/ip/keymgr/dif/dif_keymgr.h"
-#include "sw/ip/keymgr/test/utils/keymgr_testutils.h"
 #include "sw/ip/kmac/dif/dif_kmac.h"
 #include "sw/lib/sw/device/silicon_creator/otbn_boot_services.h"
 
 #include "hw/top_darjeeling/sw/autogen/top_darjeeling.h"  // Generated.
 
 OTTF_DEFINE_TEST_CONFIG();
 
-// Keymgr handle for this test.
-static dif_keymgr_t keymgr;
-
 // Message value for signature generation/verification tests.
 const char kTestMessage[] = "Test message.";
 const size_t kTestMessageLen = sizeof(kTestMessage) - 1;
@@ -37,13 +32,6 @@ static const attestation_signature_t kEcdsaSignature = {
     .s = {0x729b945d, 0x181dc116, 0x1025dba4, 0xb99828a0, 0xe7225df3,
           0x0e200e9b, 0x785690b4, 0xf47efe98}};
 
-// Sample key manager diversification data for testing.
-static const sc_keymgr_diversification_t kDiversification = {
-    .salt = {0x00010203, 0x04050607, 0x08090a0b, 0x0c0d0e0f, 0xf0f1f2f3,
-             0xf4f5f6f7, 0xf8f9fafb, 0xfcfdfeff},
-    .version = 0,
-};
-
 rom_error_t sigverify_test(void) {
   // Hash the test message.
   hmac_digest_t digest;
@@ -58,121 +46,16 @@ rom_error_t sigverify_test(void) {
   return kErrorOk;
 }
 
-rom_error_t attestation_keygen_test(void) {
-  // Check that key generations with different seeds result in different keys.
-  attestation_public_key_t pk_uds;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(kUdsAttestationKeySeed,
-                                               kDiversification, &pk_uds));
-  attestation_public_key_t pk_cdi0;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(kCdi0AttestationKeySeed,
-                                               kDiversification, &pk_cdi0));
-  attestation_public_key_t pk_cdi1;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(kCdi1AttestationKeySeed,
-                                               kDiversification, &pk_cdi1));
-  CHECK_ARRAYS_NE((unsigned char *)&pk_uds, (unsigned char *)&pk_cdi0,
-                  sizeof(pk_uds));
-  CHECK_ARRAYS_NE((unsigned char *)&pk_uds, (unsigned char *)&pk_cdi1,
-                  sizeof(pk_uds));
-  CHECK_ARRAYS_NE((unsigned char *)&pk_cdi0, (unsigned char *)&pk_cdi1,
-                  sizeof(pk_uds));
-
-  // Check that running the same key generation twice results in the same key.
-  attestation_public_key_t pk_uds_again;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(
-      kUdsAttestationKeySeed, kDiversification, &pk_uds_again));
-  CHECK_ARRAYS_EQ((unsigned char *)&pk_uds_again, (unsigned char *)&pk_uds,
-                  sizeof(pk_uds));
-
-  // Check that key generations with different diversification result in
-  // different keys.
-  sc_keymgr_diversification_t diversification_modified;
-  memcpy(&diversification_modified, &kDiversification,
-         sizeof(diversification_modified));
-  diversification_modified.salt[0] ^= 1;
-  attestation_public_key_t pk_uds_div;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(
-      kUdsAttestationKeySeed, diversification_modified, &pk_uds_div));
-  CHECK_ARRAYS_NE((unsigned char *)&pk_uds_div, (unsigned char *)&pk_uds,
-                  sizeof(pk_uds));
-  return kErrorOk;
-}
-
-rom_error_t attestation_advance_and_endorse_test(void) {
-  // Generate and save the a keypair.
-  attestation_public_key_t pk;
-  RETURN_IF_ERROR(otbn_boot_attestation_keygen(kUdsAttestationKeySeed,
-                                               kDiversification, &pk));
-  RETURN_IF_ERROR(
-      otbn_boot_attestation_key_save(kUdsAttestationKeySeed, kDiversification));
-
-  // Advance keymgr to the next stage.
-  CHECK_STATUS_OK(
-      keymgr_testutils_check_state(&keymgr, kDifKeymgrStateCreatorRootKey));
-  CHECK_STATUS_OK(keymgr_testutils_advance_state(&keymgr, &kOwnerIntParams));
-
-  // Run endorsement (should overwrite the key with randomness when done).
-  hmac_digest_t digest;
-  hmac_sha256(kTestMessage, kTestMessageLen, &digest);
-  attestation_signature_t sig;
-  RETURN_IF_ERROR(otbn_boot_attestation_endorse(&digest, &sig));
-
-  // Check that the signature is valid (recovered r == r).
-  uint32_t recovered_r[kAttestationSignatureComponentWords];
-  RETURN_IF_ERROR(otbn_boot_sigverify(&pk, &sig, &digest, recovered_r));
-  CHECK_ARRAYS_EQ(recovered_r, sig.r, ARRAYSIZE(sig.r));
-
-  // Run endorsement again (should not return an error, but should produce an
-  // invalid signature).
-  RETURN_IF_ERROR(otbn_boot_attestation_endorse(&digest, &sig));
-
-  // Check that the signature is invalid (recovered r != r).
-  RETURN_IF_ERROR(otbn_boot_sigverify(&pk, &sig, &digest, recovered_r));
-  CHECK_ARRAYS_NE(recovered_r, sig.r, ARRAYSIZE(sig.r));
-
-  return kErrorOk;
-}
-
-// N.B. This test will lock OTBN, so it needs to be the last test that runs.
-rom_error_t attestation_save_clear_key_test(void) {
-  // Save and then clear a private key.
-  RETURN_IF_ERROR(
-      otbn_boot_attestation_key_save(kUdsAttestationKeySeed, kDiversification));
-  RETURN_IF_ERROR(otbn_boot_attestation_key_clear());
-
-  // Save the private key again and check that endorsing succeeds.
-  RETURN_IF_ERROR(
-      otbn_boot_attestation_key_save(kUdsAttestationKeySeed, kDiversification));
-  hmac_digest_t digest;
-  hmac_sha256(kTestMessage, kTestMessageLen, &digest);
-  attestation_signature_t sig;
-  RETURN_IF_ERROR(otbn_boot_attestation_endorse(&digest, &sig));
-
-  // Clear the key and check that endorsing now fails (it should even lock
-  // OTBN).
-  RETURN_IF_ERROR(otbn_boot_attestation_key_clear());
-  hmac_sha256(kTestMessage, kTestMessageLen, &digest);
-  CHECK(otbn_boot_attestation_endorse(&digest, &sig) ==
-        kErrorOtbnExecutionFailed);
-  return kErrorOk;
-}
-
 bool test_main(void) {
   status_t result = OK_STATUS();
 
   // Initialize the entropy complex, KMAC, and the key manager.
   CHECK_STATUS_OK(entropy_complex_init());
-  dif_kmac_t kmac;
-  CHECK_STATUS_OK(keymgr_testutils_startup(&keymgr, &kmac));
-  CHECK_STATUS_OK(
-      keymgr_testutils_check_state(&keymgr, kDifKeymgrStateCreatorRootKey));
 
   // Load the boot services OTBN app.
   CHECK(otbn_boot_app_load() == kErrorOk);
 
   EXECUTE_TEST(result, sigverify_test);
-  EXECUTE_TEST(result, attestation_keygen_test);
-  EXECUTE_TEST(result, attestation_advance_and_endorse_test);
-  EXECUTE_TEST(result, attestation_save_clear_key_test);
 
   return status_ok(result);
 }